fix initial balance logic and add edit for cycle data

backend/apps/farms/views.py

@@ -6,16 +6,14 @@ from rest_framework.response import Response
 from apps.accounts.models import User
 from apps.farms.models import Cycle, Flock, Kandang, Site
 from apps.farms.serializers import CycleSerializer, FlockSerializer, KandangSerializer, SiteSerializer
-from apps.operations.models import FeedSacks, ManualInput
 from apps.operations.services.feed_sacks import (
-    ensure_opening_feed_sack_snapshot,
+    cleanup_opening_balance_feed_rows,
     recompute_feed_sack_in_totals,
 )
 from apps.operations.services.karung_web import (
     initial_balance_accuracy,
     pull_initial_balance_iot,
 )
-from apps.operations.services.manual_input import recompute_manual_totals
 
 
 class IsSuperAdminForWrite(permissions.BasePermission):
@@ -113,7 +111,6 @@ class CycleViewSet(viewsets.ModelViewSet):
                 )
 
         iot_in, sync_error = pull_initial_balance_iot(cycle, balance_date)
-        manual_row = ManualInput.objects.filter(cycle=cycle, date=balance_date).first()
         return Response(
             {
                 "cycle": cycle.pk,
@@ -125,7 +122,7 @@ class CycleViewSet(viewsets.ModelViewSet):
                     else None
                 ),
                 "manual": feed_in_manual,
-                "manual_total": manual_row.feed_in_manual_total if manual_row else feed_in_manual,
+                "manual_total": feed_in_manual,
                 "iot": iot_in,
                 "accuracy": initial_balance_accuracy(feed_in_manual, iot_in),
                 "sync_error": sync_error,
@@ -137,9 +134,10 @@ class CycleViewSet(viewsets.ModelViewSet):
         """Save the feed-in balance for the cycle (Saldo Awal).
 
         Sets ``feed_initial_balance`` on the cycle (the only cycle field this
-        feature writes — never during cycle creation), records the manual feed-in
-        for the balance date, then pulls the IoT-detected "in" for that date from
-        karung-web-admin ``/api/combined`` and returns a manual vs IoT accuracy figure.
+        feature writes — never during cycle creation). Opening balance is kept on
+        the cycle for saldo only and is not written into daily FeedSacks rows.
+        Pulls the IoT-detected "in" for that date from karung-web-admin
+        ``/api/combined`` and returns a manual vs IoT accuracy figure.
         """
         cycle = self.get_object()
 
@@ -166,6 +164,9 @@ class CycleViewSet(viewsets.ModelViewSet):
                 status=status.HTTP_400_BAD_REQUEST,
             )
 
+        previous_date = cycle.feed_initial_balance_date
+        previous_balance = cycle.feed_initial_balance
+
         cycle.feed_initial_balance = feed_in_manual
         cycle.feed_initial_balance_date = balance_date
         cycle.save(
@@ -175,21 +176,17 @@ class CycleViewSet(viewsets.ModelViewSet):
         # Pull IoT "in" at the balance date from karung-web-admin /api/combined.
         iot_in, sync_error = pull_initial_balance_iot(cycle, balance_date)
 
-        # Record the manual feed-in for the balance date.
-        ManualInput.objects.update_or_create(
-            cycle=cycle,
-            date=balance_date,
-            defaults={"feed_in_manual": feed_in_manual},
+        cleanup_opening_balance_feed_rows(
+            cycle,
+            previous_date=previous_date,
+            previous_balance=previous_balance,
+            balance_date=balance_date,
+            balance_amount=feed_in_manual,
         )
-        recompute_manual_totals(cycle)
-
-        # FeedSacks in_total always includes the initial balance as its base.
         recompute_feed_sack_in_totals(cycle)
-        ensure_opening_feed_sack_snapshot(cycle, balance_date)
 
         accuracy = initial_balance_accuracy(feed_in_manual, iot_in)
 
-        manual_row = ManualInput.objects.filter(cycle=cycle, date=balance_date).first()
         return Response(
             {
                 "cycle": cycle.pk,
@@ -201,7 +198,7 @@ class CycleViewSet(viewsets.ModelViewSet):
                     else None
                 ),
                 "manual": feed_in_manual,
-                "manual_total": manual_row.feed_in_manual_total if manual_row else feed_in_manual,
+                "manual_total": feed_in_manual,
                 "iot": iot_in,
                 "accuracy": accuracy,
                 "sync_error": sync_error,